topology2: add development tplg to test playback with 2 cores #7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
reviewed
Jun 9, 2023
| @@ -37,6 +37,9 @@ DEEPBUFFER_D0I3_COMPATIBLE=true" | |||
| "cavs-nocodec-multicore\;sof-mtl-nocodec-multicore\;PLATFORM=mtl,SSP1_ENABLED=true,SSP0_CORE_ID=0,\ | |||
| SSP1_CORE_ID=1,SSP2_CORE_ID=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-nocodec.bin" | |||
|
|
|||
| "cavs-nocodec-multicore\;sof-mtl-nocodec-multicore-ssp0-ssp2\;PLATFORM=mtl,SSP1_ENABLED=false,\ | |||
| SSP0_CORE_ID=0,SSP2_CORE_ID=1,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-nocodec.bin" | |||
There was a problem hiding this comment.
nit-pick: SSP0_CORE_ID is 0 by default. so no need to set it again here
There was a problem hiding this comment.
nit-pick: SSP0_CORE_ID is 0 by default. so no need to set it again here
@ranj063 Thank you! I've removed this.
ranj063
approved these changes
Jun 9, 2023
RanderWang
approved these changes
Jun 9, 2023
|
@kv2019i @plbossart Can you help review this PR ? The CI failures are not caused by this topology PR as we haven't enabled multi-core test yet. This PR is to allow regular CI testing from a simple multi-core case. |
|
@ranj063 @RanderWang @plbossart @kv2019i I also add the same 2-core nocodec topology for TGL. So we can compare test results on MTL and TGL. |
This is to allow CI to test a simple multicore playback case on MTL/TGL/ADL: SSP0 playback on core 0 and SSP2 playback on core 1. Capture uses core 0 only atm. More multicore usage will be introduced later. Signed-off-by: Mengdong Lin <[email protected]>
|
Manifest-check failing due to regression, fix in #7782 Otherwise looks normal, proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow CI to test a simple multicore playback case on MTL: SSP0 playback on core 0 and SSP2 playback on core 1.
Capture uses core 0 only atm. More multicore usage will be introduced later.
The topology binary is sof-
platform-nocodec-multicore-ssp0-ssp2.tplg. It reuses existingSSP1_ENABLED = falseto restrict number of pipelines.Tested on MTL and TGL RVP.
Update history:
v2: remove unnecessary 'SSP0_CORE_ID=0' as core 0 is default.
v3: add the same 2-core topology for TGL, so we can compare test result on MTL and TGL.
v4: add the same 2-core topology to ADL, for testing on one more platform.